Mmuzaf commented on code in PR #10082:
URL: https://github.com/apache/ignite/pull/10082#discussion_r898239158
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotRestoreProcess.java:
##########
@@ -621,10 +620,20 @@ private
IgniteInternalFuture<SnapshotRestoreOperationResponse> prepare(SnapshotO
* @param cacheDir Cache directory.
* @return Temporary directory.
*/
- private static File formatTmpDirName(File cacheDir) {
+ static File formatTmpDirName(File cacheDir) {
return new File(cacheDir.getParent(), TMP_CACHE_DIR_PREFIX +
cacheDir.getName());
}
+ /**
+ * @param tmpCacheDir Temporary cache directory.
+ * @return Cache or group id.
+ */
+ static int tmpDirGroupId(File tmpCacheDir) {
Review Comment:
It seems the naming is not correct. We are getting the groupId here,
however, it is not temporary. I think it is better to consider the following
names: `groupIdFromTmpDir` or just `restoredCacheId`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
