valepakh commented on code in PR #897: URL: https://github.com/apache/ignite-3/pull/897#discussion_r906099216
########## modules/cli/src/main/java/org/apache/ignite/cli/call/cliconfig/CliConfigCreateProfileCall.java: ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.cli.call.cliconfig; + +import jakarta.inject.Inject; +import jakarta.inject.Singleton; +import org.apache.ignite.cli.config.ConfigManager; +import org.apache.ignite.cli.config.ConfigManagerProvider; +import org.apache.ignite.cli.config.Profile; +import org.apache.ignite.cli.core.call.Call; +import org.apache.ignite.cli.core.call.CallOutput; +import org.apache.ignite.cli.core.call.DefaultCallOutput; + +/** + * Create CLI profile. + */ +@Singleton +public class CliConfigCreateProfileCall implements Call<CliConfigCreateProfileCallInput, String> { + + @Inject + private ConfigManagerProvider configManagerProvider; + + @Override + public CallOutput<String> execute(CliConfigCreateProfileCallInput input) { + ConfigManager configManager = configManagerProvider.get(); + Profile copyFrom = null; + if (input.getCopyFrom() != null) { + copyFrom = configManager.getConfig(input.getCopyFrom()); + } + + String profileName = input.getName(); + Profile newProfile = configManager.createProfile(profileName); + + if (copyFrom != null) { + newProfile.setProperties(copyFrom); + } + + if (input.isActivate()) { + configManager.setCurrentProfile(profileName); + } + return DefaultCallOutput.success("Profile " + profileName + " successfully created."); Review Comment: ```suggestion return DefaultCallOutput.success("Profile " + profileName + " was created successfully."); ``` I would suggest keeping this message similar to the CliConfigActivateCall. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
