vldpyatkov commented on code in PR #842:
URL: https://github.com/apache/ignite-3/pull/842#discussion_r912019437
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/configuration/storage/ItRebalanceDistributedTest.java:
##########
@@ -481,8 +481,7 @@ private static class Node {
metaStorageManager,
schemaManager);
- //TODO: Get rid of it after IGNITE-17062.
- sqlQueryProcessor = new SqlQueryProcessor(registry,
clusterService, tableManager, dataStorageMgr, Map::of);
+ sqlQueryProcessor = new SqlQueryProcessor(registry,
clusterService, tableManager, schemaManager, dataStorageMgr, Map::of);
Review Comment:
Why did you not remove sqlQueryProcessor?
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteNodeRestartTest.java:
##########
@@ -282,13 +282,13 @@ private List<IgniteComponent> startPartialNode(
schemaManager
);
- //TODO: Get rid of it after IGNITE-17062.
- SqlQueryProcessor queryProcessor = new SqlQueryProcessor(registry,
clusterSvc, tableManager, dataStorageManager, Map::of);
+ SqlQueryProcessor queryProcessor =
+ new SqlQueryProcessor(registry, clusterSvc, tableManager,
schemaManager, dataStorageManager, Map::of);
Review Comment:
I am sure queryProcessor is not required here anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
