ptupitsyn commented on code in PR #10123:
URL: https://github.com/apache/ignite/pull/10123#discussion_r912076721


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/service/IgniteServiceProcessor.java:
##########
@@ -1858,6 +1862,9 @@ private void 
processDynamicCacheChangeRequest(DynamicCacheChangeBatch msg) {
             depActions.servicesToUndeploy(toUndeploy);
 
             msg.servicesDeploymentActions(depActions);
+
+            // Remove the names from the service-by-name map as well

Review Comment:
   Oops :facepalm: , somehow I missed that. 
   Both ways are ok for me (`toUndeploy.values().forEach` or one by one inside 
`removeIf`).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to