sanpwc commented on code in PR #842:
URL: https://github.com/apache/ignite-3/pull/842#discussion_r913248686
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/SqlSchemaManagerImpl.java:
##########
@@ -79,11 +85,15 @@ public SqlSchemaManagerImpl(
});
schemasVv.whenComplete((token, stringIgniteSchemaMap, throwable) -> {
- rebuild(token, stringIgniteSchemaMap);
+ if (throwable != null) {
+ throw new IgniteInternalException("Couldn't evaluate sql
schemas for causality token: " + token, throwable);
Review Comment:
Why we need this? Who and how will handle such exception?
What about completing calciteSchemaVv with same exception instead of
newCalciteSchema?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
