zstan commented on code in PR #912:
URL: https://github.com/apache/ignite-3/pull/912#discussion_r913723850
##########
modules/schema/src/test/java/org/apache/ignite/internal/schema/configuration/SchemaConfigurationConverterTest.java:
##########
@@ -96,7 +96,9 @@ public void createRegistry() throws ExecutionException,
InterruptedException {
SchemaBuilders.column("COL2",
ColumnType.DOUBLE).build(),
SchemaBuilders.column("A", ColumnType.INT8).build(),
SchemaBuilders.column("B", ColumnType.INT8).build(),
- SchemaBuilders.column("C", ColumnType.INT8).build()
+ SchemaBuilders.column("C", ColumnType.INT8).build(),
+ SchemaBuilders.column("DUR",
ColumnType.duration()).build(),
+ SchemaBuilders.column("PER",
ColumnType.period()).build()
Review Comment:
This is not trivial for now as i can see, we need smt like SchemaTestUtils
here but for ColumnTypeSpec, so i prefer to move this activity into another
issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
