korlov42 commented on code in PR #912:
URL: https://github.com/apache/ignite-3/pull/912#discussion_r913774032
##########
modules/client/src/test/java/org/apache/ignite/client/ClientTupleTest.java:
##########
@@ -149,7 +151,9 @@ public void testTypedGetters() {
new ClientColumn("TIME", ClientDataType.TIME, false, false, 9),
new ClientColumn("DATE", ClientDataType.DATE, false, false,
10),
new ClientColumn("DATETIME", ClientDataType.DATETIME, false,
false, 11),
- new ClientColumn("TIMESTAMP", ClientDataType.TIMESTAMP, false,
false, 12)
+ new ClientColumn("TIMESTAMP", ClientDataType.TIMESTAMP, false,
false, 12),
+ new ClientColumn("DURATION", ClientDataType.DURATION, false,
false, 13),
+ new ClientColumn("PERIOD", ClientDataType.PERIOD, false,
false, 14)
});
Review Comment:
unfortunately, suggested approach doesn't fix the issue: if a new type is
added then this check will not fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
