tkalkirill commented on code in PR #907:
URL: https://github.com/apache/ignite-3/pull/907#discussion_r914877427
##########
modules/page-memory/src/test/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointWorkflowTest.java:
##########
@@ -181,13 +171,13 @@ void testMarkCheckpointBegin() throws Exception {
CheckpointReadWriteLock readWriteLock = newReadWriteLock(log);
- List<FullPageId> dirtyPages = List.of(new FullPageId(0, 0), new
FullPageId(1, 0), new FullPageId(2, 0));
+ List<FullPageId> dirtyPages = List.of(of(0, 0, 0), of(0, 0, 1), of(0,
0, 2));
Review Comment:
I can rename, but the code can be cumbersome, this is a private method, can
we leave it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
