korlov42 commented on code in PR #933:
URL: https://github.com/apache/ignite-3/pull/933#discussion_r917713525
##########
modules/core/src/main/java/org/apache/ignite/internal/thread/LogUncaughtExceptionHandler.java:
##########
@@ -33,6 +33,6 @@ public LogUncaughtExceptionHandler(IgniteLogger log) {
/** {@inheritDoc} */
@Override
public void uncaughtException(Thread t, Throwable e) {
- log.error("Uncaught exception in thread {}", e, t);
+ log.debug("Uncaught exception [thread={}]", e, t);
Review Comment:
ERROR requires immediate action. Is it OK to log it at WARN? The reason I
decided to change this is because this handler is more like a stub. I believe
that right way to handle the exception is to analyse it though some common
failure handler, but not just put the line into log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
