PakhomovAlexander commented on code in PR #905: URL: https://github.com/apache/ignite-3/pull/905#discussion_r919815502
########## modules/node-management/pom.xml: ########## @@ -0,0 +1,156 @@ +<?xml version="1.0" encoding="UTF-8"?> Review Comment: The problem here is that `rest` module should know about `NodeManagementController` in order to generate the openapi specification at compile time. `NodeManagementController` depends on `LifecycleManager` from `runner` module. And `runner` depends on `rest` module. Here is a cyclic dependency. So, I've added `node-management` in order to move all REST-related stuff out of `runner` module and solve the cyclic dependency problem. Your comment makes sense and I think there is a couple of ways we could go: - choose a better name for the new module and/or move it under /rest/ path (make it a submodule of rest) - move all stuff from `node-management` back to `runner` and try to solve the compile-time dependency between `runner` and `rest` in a different way. Any thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
