sanpwc commented on code in PR #927: URL: https://github.com/apache/ignite-3/pull/927#discussion_r919893040
########## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaService.java: ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.replicator; + +import java.util.concurrent.CompletableFuture; +import org.apache.ignite.internal.replicator.message.ReplicaMessagesFactory; +import org.apache.ignite.internal.replicator.message.ReplicaRequest; +import org.apache.ignite.internal.replicator.message.ReplicaResponse; +import org.apache.ignite.network.ClusterNode; + +/** + * Replica service. + */ +public interface ReplicaService extends AutoCloseable { + /** Replicator network message factory. */ + static final ReplicaMessagesFactory REPLICA_MESSAGES_FACTORY = new ReplicaMessagesFactory(); + + /** Network timeout. */ + static final int RPC_TIMEOUT = 3000; Review Comment: I'd favor adding all such implementation specific stuff in corresponding implementation specific tickets. Let's remove it from given PR. Otherwise we will bogged down in timeout exception handling details. ########## modules/replicator/src/main/java/org/apache/ignite/hlc/HybridTimestamp.java: ########## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.hlc; + +import java.io.Serializable; +import org.apache.ignite.internal.tostring.S; +import org.jetbrains.annotations.Nullable; + +/** + * A hybrid timestamp that combines physical clock and logical clock. + */ +public class HybridTimestamp implements Comparable<HybridTimestamp>, Serializable { Review Comment: I don't think that we need HybridTimestamp in order to introduce ReplicaListener interface. I believe that timestamp will rather be a part of read only replica requests that an explicit parameter of applyReadOnly() method. ########## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaService.java: ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.replicator; + +import java.util.concurrent.CompletableFuture; +import org.apache.ignite.internal.replicator.message.ReplicaMessagesFactory; +import org.apache.ignite.internal.replicator.message.ReplicaRequest; +import org.apache.ignite.internal.replicator.message.ReplicaResponse; +import org.apache.ignite.network.ClusterNode; + +/** + * Replica service. + */ +public interface ReplicaService extends AutoCloseable { + /** Replicator network message factory. */ + static final ReplicaMessagesFactory REPLICA_MESSAGES_FACTORY = new ReplicaMessagesFactory(); + + /** Network timeout. */ + static final int RPC_TIMEOUT = 3000; + + /** + * Determines the replica server or not. + * If the replica is not a server, it delegates all command to a remote replica server. + * + * @return True when the replica is server, false when this is only client service. + */ + boolean isServer(); Review Comment: I still don't think that we need given method. ########## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaService.java: ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.replicator; + +import java.util.concurrent.CompletableFuture; +import org.apache.ignite.internal.replicator.message.ReplicaMessagesFactory; +import org.apache.ignite.internal.replicator.message.ReplicaRequest; +import org.apache.ignite.internal.replicator.message.ReplicaResponse; +import org.apache.ignite.network.ClusterNode; + +/** + * Replica service. + */ +public interface ReplicaService extends AutoCloseable { + /** Replicator network message factory. */ + static final ReplicaMessagesFactory REPLICA_MESSAGES_FACTORY = new ReplicaMessagesFactory(); + + /** Network timeout. */ + static final int RPC_TIMEOUT = 3000; + + /** + * Determines the replica server or not. + * If the replica is not a server, it delegates all command to a remote replica server. + * + * @return True when the replica is server, false when this is only client service. + */ + boolean isServer(); + + /** + * Handles replication request. + * + * @param request Request. + * @return Future to response. + */ + CompletableFuture<ReplicaResponse> processRequest(ReplicaRequest request); + + + /** + * Invokes an action in replica. Review Comment: Here and in other places I'd rather use javadocs similar to ones we have in MessagingService, e.g. "Node in which a request will be sent." -> "Recipient cluster node." Let's also clarify and denote guaranties explicitly, e.g. are invokes ordered? ########## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaService.java: ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.replicator; + +import java.util.concurrent.CompletableFuture; +import org.apache.ignite.internal.replicator.message.ReplicaMessagesFactory; +import org.apache.ignite.internal.replicator.message.ReplicaRequest; +import org.apache.ignite.internal.replicator.message.ReplicaResponse; +import org.apache.ignite.network.ClusterNode; + +/** + * Replica service. + */ +public interface ReplicaService extends AutoCloseable { + /** Replicator network message factory. */ + static final ReplicaMessagesFactory REPLICA_MESSAGES_FACTORY = new ReplicaMessagesFactory(); + + /** Network timeout. */ + static final int RPC_TIMEOUT = 3000; + + /** + * Determines the replica server or not. + * If the replica is not a server, it delegates all command to a remote replica server. + * + * @return True when the replica is server, false when this is only client service. + */ + boolean isServer(); + + /** + * Handles replication request. Review Comment: Well, generally speaking that's not true, because lot's of ReplicaRequests aren't replication ones. ########## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaService.java: ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.replicator; + +import java.util.concurrent.CompletableFuture; +import org.apache.ignite.internal.replicator.message.ReplicaMessagesFactory; +import org.apache.ignite.internal.replicator.message.ReplicaRequest; +import org.apache.ignite.internal.replicator.message.ReplicaResponse; +import org.apache.ignite.network.ClusterNode; + +/** + * Replica service. + */ +public interface ReplicaService extends AutoCloseable { + /** Replicator network message factory. */ + static final ReplicaMessagesFactory REPLICA_MESSAGES_FACTORY = new ReplicaMessagesFactory(); + + /** Network timeout. */ + static final int RPC_TIMEOUT = 3000; + + /** + * Determines the replica server or not. + * If the replica is not a server, it delegates all command to a remote replica server. + * + * @return True when the replica is server, false when this is only client service. + */ + boolean isServer(); + + /** + * Handles replication request. + * + * @param request Request. + * @return Future to response. Review Comment: Here and in other places, just "Response future". ########## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaService.java: ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.replicator; + +import java.util.concurrent.CompletableFuture; +import org.apache.ignite.internal.replicator.message.ReplicaMessagesFactory; +import org.apache.ignite.internal.replicator.message.ReplicaRequest; +import org.apache.ignite.internal.replicator.message.ReplicaResponse; +import org.apache.ignite.network.ClusterNode; + +/** + * Replica service. + */ +public interface ReplicaService extends AutoCloseable { + /** Replicator network message factory. */ + static final ReplicaMessagesFactory REPLICA_MESSAGES_FACTORY = new ReplicaMessagesFactory(); + + /** Network timeout. */ + static final int RPC_TIMEOUT = 3000; + + /** + * Determines the replica server or not. + * If the replica is not a server, it delegates all command to a remote replica server. + * + * @return True when the replica is server, false when this is only client service. + */ + boolean isServer(); + + /** + * Handles replication request. + * + * @param request Request. + * @return Future to response. + */ + CompletableFuture<ReplicaResponse> processRequest(ReplicaRequest request); + + + /** + * Invokes an action in replica. + * + * @param node Node in which a request will be sent. + * @param request Request. + * @return Future to response. + */ + CompletableFuture<ReplicaResponse> invoke(ClusterNode node, ReplicaRequest request); + + /** + * Invokes an action in replica on the specific storage. + * + * @param node Node in which a request will be sent. + * @param request Request. + * @param storageId Storage id. + * @return Future to response. + */ + CompletableFuture<ReplicaResponse> invoke(ClusterNode node, ReplicaRequest request, String storageId); Review Comment: Not sure whether we will use string as storageId, let's add todo with corresponding ticket here. ########## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/Replica.java: ########## @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.replicator; + +import java.util.concurrent.CompletableFuture; +import org.apache.ignite.internal.cluster.management.ClusterManagementGroupManager; +import org.apache.ignite.internal.replicator.message.ReadOnlyMultyEntryRequest; +import org.apache.ignite.internal.replicator.message.ReadOnlyRequest; +import org.apache.ignite.internal.replicator.message.ReadOnlySingleEntryRequest; +import org.apache.ignite.internal.replicator.message.ReadWriteMultiEntryRequest; +import org.apache.ignite.internal.replicator.message.ReadWriteRequest; +import org.apache.ignite.internal.replicator.message.ReadWriteSingleEntryRequest; +import org.apache.ignite.internal.replicator.message.ReplicaRequest; +import org.apache.ignite.internal.replicator.message.ReplicaResponse; +import org.apache.ignite.internal.replicator.message.container.MultiEntryContainer; +import org.apache.ignite.internal.replicator.message.container.SingleEntryContainer; +import org.apache.ignite.lang.IgniteInternalException; +import org.apache.ignite.lang.IgniteStringFormatter; +import org.apache.ignite.network.ClusterNode; +import org.apache.ignite.network.MessagingService; +import org.apache.ignite.network.TopologyService; +import org.apache.ignite.raft.client.Peer; +import org.apache.ignite.raft.client.service.RaftGroupService; + +/** + * Replica server. + */ +public class Replica implements ReplicaService { + /** Raft client. */ + private final RaftGroupService raftClient; Review Comment: I'd favor adding all implementation specific details in corresponding tickets. ########## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/Replica.java: ########## @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.replicator; + +import java.util.concurrent.CompletableFuture; +import org.apache.ignite.internal.cluster.management.ClusterManagementGroupManager; +import org.apache.ignite.internal.replicator.message.ReadOnlyMultyEntryRequest; +import org.apache.ignite.internal.replicator.message.ReadOnlyRequest; +import org.apache.ignite.internal.replicator.message.ReadOnlySingleEntryRequest; +import org.apache.ignite.internal.replicator.message.ReadWriteMultiEntryRequest; +import org.apache.ignite.internal.replicator.message.ReadWriteRequest; +import org.apache.ignite.internal.replicator.message.ReadWriteSingleEntryRequest; +import org.apache.ignite.internal.replicator.message.ReplicaRequest; +import org.apache.ignite.internal.replicator.message.ReplicaResponse; +import org.apache.ignite.internal.replicator.message.container.MultiEntryContainer; +import org.apache.ignite.internal.replicator.message.container.SingleEntryContainer; +import org.apache.ignite.lang.IgniteInternalException; +import org.apache.ignite.lang.IgniteStringFormatter; +import org.apache.ignite.network.ClusterNode; +import org.apache.ignite.network.MessagingService; +import org.apache.ignite.network.TopologyService; +import org.apache.ignite.raft.client.Peer; +import org.apache.ignite.raft.client.service.RaftGroupService; + +/** + * Replica server. + */ +public class Replica implements ReplicaService { + /** Raft client. */ + private final RaftGroupService raftClient; + + /** Replica group identity, this id is the same as the considered partition's id. */ + private final String partitionId; + + /** Local cluster node. */ + private final ClusterNode localNode; + + /** Logical topology service. */ + private final ClusterManagementGroupManager logicalTopologyService; + + /** Topology service. */ + private final TopologyService topologyService; + + /** Replica listener. */ + private final ReplicaListener listener; + + /** Message service. */ + private final MessagingService messagingService; + + /** + * The constructor of replica server. + * + * @param partitionId Identity. + * @param topologyService Topology service. + * @param messagingService Message service. + * @param logicalTopologyService Logical topology service. + * @param raftGroupService Raft client. + * @param listener Replica listener. + */ + public Replica( Review Comment: Let's remove all implementation specific stuff for now. ########## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaService.java: ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.replicator; + +import java.util.concurrent.CompletableFuture; +import org.apache.ignite.internal.replicator.message.ReplicaMessagesFactory; +import org.apache.ignite.internal.replicator.message.ReplicaRequest; +import org.apache.ignite.internal.replicator.message.ReplicaResponse; +import org.apache.ignite.network.ClusterNode; + +/** + * Replica service. + */ +public interface ReplicaService extends AutoCloseable { + /** Replicator network message factory. */ + static final ReplicaMessagesFactory REPLICA_MESSAGES_FACTORY = new ReplicaMessagesFactory(); + + /** Network timeout. */ + static final int RPC_TIMEOUT = 3000; + + /** + * Determines the replica server or not. + * If the replica is not a server, it delegates all command to a remote replica server. + * + * @return True when the replica is server, false when this is only client service. + */ + boolean isServer(); + + /** + * Handles replication request. + * + * @param request Request. + * @return Future to response. + */ + CompletableFuture<ReplicaResponse> processRequest(ReplicaRequest request); Review Comment: That should be a method of Replica not ReplicaService. If it's not currently possible to specify possible exceptions in throws clause please add todo linked to any appropriate ticket, probably https://issues.apache.org/jira/browse/IGNITE-17258. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
