vldpyatkov commented on code in PR #927: URL: https://github.com/apache/ignite-3/pull/927#discussion_r921134087
########## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaService.java: ########## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.replicator; + +import java.util.concurrent.CompletableFuture; +import org.apache.ignite.internal.replicator.message.ReplicaRequest; +import org.apache.ignite.internal.replicator.message.ReplicaResponse; +import org.apache.ignite.lang.IgniteStringFormatter; +import org.apache.ignite.network.ClusterNode; +import org.apache.ignite.network.MessagingService; +import org.apache.ignite.network.TopologyService; + +/** + * The service is intended to execute requests on replicas. + * TODO:IGNITE-17255 Implement ReplicaService. + */ +public class ReplicaService implements AutoCloseable { + /** Network timeout. */ + private static final int RPC_TIMEOUT = 3000; + + /** Replica manager. */ + private final ReplicaManager replicaManager; + + /** Message service. */ + private final MessagingService messagingService; + + /** Local node. */ + private final ClusterNode localNode; + + /** + * The constructor of replica client. + * + * @param replicaManager Replica manager. + * @param messagingService Cluster message service. + * @param topologyService Topology service. + */ + public ReplicaService( + ReplicaManager replicaManager, + MessagingService messagingService, + TopologyService topologyService + ) { + this.replicaManager = replicaManager; + this.messagingService = messagingService; + + this.localNode = topologyService.localMember(); + } + + /** + * Sends request to the replica node. + * + * @param node Cluster node which holds a replica. + * @param req Replica request. + * @return Future to response. + */ + private CompletableFuture<ReplicaResponse> sendToReplica(ClusterNode node, ReplicaRequest req) { + if (localNode.equals(node)) { + Replica replica = replicaManager.replica(req.partitionId()); + + if (replica == null) { + //TODO:IGNITE-17255 Provide an exceptional response when the replica is absent. + } + + return CompletableFuture.completedFuture(replica.processRequest(req)); Review Comment: Here will be a future which connected with network communication. In case where the request executed locally, we have no the communication. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
