ibessonov commented on code in PR #920:
URL: https://github.com/apache/ignite-3/pull/920#discussion_r921924127


##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointPagesWriter.java:
##########
@@ -59,7 +66,10 @@ public class CheckpointPagesWriter implements Runnable {
      * <p>Overall pages to write may be greater than this queue, since it may 
be necessary to retire write some pages due to unsuccessful
      * page write lock acquisition
      */
-    private final CheckpointDirtyPagesQueue writePageIds;
+    private final IgniteConcurrentMultiPairQueue<PersistentPageMemory, 
FullPageId> writePageIds;
+
+    /** Queue of dirty partition IDs to update {@link PartitionMetaIo} under 
this task. */

Review Comment:
   Yes, this is better



##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointPagesWriter.java:
##########
@@ -212,4 +241,53 @@ public void writePage(FullPageId fullPageId, ByteBuffer 
buf, int tag) throws Ign
             }
         };
     }
+
+    /**
+     * Updates the partition {@link PartitionMetaIo} (pageIdx == 0).

Review Comment:
   Sure



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to