xtern commented on code in PR #10145:
URL: https://github.com/apache/ignite/pull/10145#discussion_r921949033


##########
modules/platforms/dotnet/Apache.Ignite.Core/Services/ServiceConfiguration.cs:
##########
@@ -91,6 +100,11 @@ internal void Write(IBinaryRawWriter w)
                 w.WriteObject(NodeFilter);
             else
                 w.WriteObject<object>(null);
+            
+            if (Interceptors != null)
+                w.WriteCollection(Interceptors as ICollection);

Review Comment:
   @ptupitsyn, maybe i can just use writeObject/readObject instead of 
writeCollection/readCollection/etc? (It seems to work fine)
   
   I can't figure out how to add the suggested overload without duplicating 
code or converting from a generic collection to a non-generic in 
BinaryWriter/BinaryUtils.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to