AMashenkov commented on code in PR #945:
URL: https://github.com/apache/ignite-3/pull/945#discussion_r925437228
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/AsyncSqlCursorImpl.java:
##########
@@ -71,6 +77,10 @@ public CompletionStage<BatchedResult<T>>
requestNextAsync(int rows) {
t = t.getCause();
}
+ if (tx != null) {
Review Comment:
What are the cases when transaction must or shouldn't be rolled back?
One the one side. Here, as we already have a cursor, the query is already
parsed and mapped to nodes.
So, we can't be sure whether any lock was obtained or not.
On the other side, it is a client API part and server errors are processed
on the server-side.
Errors on the client side (e.g. disconnect and marshaller failures) can be
handle by the user,
However, I doubt any error is recoverable here and TX will be likely aborted
by the user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
