tkalkirill commented on code in PR #952:
URL: https://github.com/apache/ignite-3/pull/952#discussion_r927566597
##########
modules/api/src/main/java/org/apache/ignite/configuration/schemas/table/TablesConfigurationSchema.java:
##########
@@ -29,6 +29,10 @@
@SuppressWarnings("PMD.UnusedPrivateField")
@ConfigurationRoot(rootName = "table", type = ConfigurationType.DISTRIBUTED)
public class TablesConfigurationSchema {
+ /** Global integer id counter. */
+ @Value(hasDefault = true)
+ public int globalIdCounter = 0;
Review Comment:
Is this the global table identifier? why is it not clearly named? what
happens if it overflows?
##########
modules/api/src/main/java/org/apache/ignite/configuration/schemas/table/TableConfigurationSchema.java:
##########
@@ -35,6 +36,12 @@ public class TableConfigurationSchema {
@InjectedName
public String name;
+ /** Integer table id. */
+ @Immutable
+ @Range(min = 1, max = Integer.MAX_VALUE)
+ @Value(hasDefault = true)
+ public int intId = 1;
Review Comment:
Why such a name? seems to be more correct just **id**.
Why such a range?
Can we use UUID as an identifier?
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/store/FilePageStoreManager.java:
##########
@@ -168,30 +168,30 @@ public long allocatePage(int grpId, int partId, byte
flags) throws IgniteInterna
/**
* Initializing the file page stores for a group.
*
- * @param grpName Group name.
- * @param grpId Group ID.
+ * @param tableName Table name.
+ * @param groupId Integer table id.
Review Comment:
**tableId** ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
