ygerzhedovich commented on code in PR #944:
URL: https://github.com/apache/ignite-3/pull/944#discussion_r928847894
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/definition/builder/ColumnDefinitionBuilderImpl.java:
##########
@@ -78,6 +79,9 @@ public ColumnDefinitionBuilderImpl withHints(Map<String,
String> hints) {
/** {@inheritDoc} */
@Override
public ColumnDefinition build() {
- return new ColumnDefinitionImpl(colName, colType, nullable,
defValExpr);
+ var defaultSupp = defValExpr == null
Review Comment:
I would say the following situation:
ColumnDefinitionBuilderImpl builder = ......;
builder.asNullable(false);
builder.withDefaultValueExpression(null);
What does it mean? For me it user mistake and we should say about it. But
maybe you are right and we just should interpret it as the column value should
be define during insert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
