ibessonov commented on code in PR #947:
URL: https://github.com/apache/ignite-3/pull/947#discussion_r930794012
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PartitionMetaManager.java:
##########
@@ -95,28 +99,34 @@ public PartitionMeta readOrCreateMeta(
long partitionMetaPageId =
partitionMetaPageId(groupPartitionId.getPartitionId());
try {
- if (filePageStore.readWithoutPageIdCheck(partitionMetaPageId,
buffer, false)) {
+ if (containsPartitionMetaIo(filePageStore)) {
Review Comment:
Please use the word "page" instead of "IO".
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/store/AbstractFilePageStoreIo.java:
##########
@@ -486,11 +482,12 @@ private boolean read0(
int n = readWithFailover(pageBuf, pageOff);
+ // TODO: IGNITE-17397 Investigate the ability to read a empty page
Review Comment:
```suggestion
// TODO: IGNITE-17397 Investigate the ability to read an empty
page
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
