SammyVimes commented on code in PR #901:
URL: https://github.com/apache/ignite-3/pull/901#discussion_r932933053
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointWorkflow.java:
##########
@@ -219,15 +226,17 @@ public Checkpoint markCheckpointBegin(
*/
public void markCheckpointEnd(Checkpoint chp) throws
IgniteInternalCheckedException {
synchronized (this) {
- chp.progress.clearCounters();
-
for (DataRegion<PersistentPageMemory> dataRegion : dataRegions) {
dataRegion.pageMemory().finishCheckpoint();
}
}
if (chp.hasDelta()) {
checkpointMarkersStorage.onCheckpointEnd(chp.progress.id());
+
+ chp.progress.pagesToWrite(null);
Review Comment:
No, I was just curious, current approach is good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
