ademakov commented on code in PR #965:
URL: https://github.com/apache/ignite-3/pull/965#discussion_r937641335
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTupleSchema.java:
##########
@@ -289,10 +289,23 @@ public static int nullMapSize(int numElements) {
}
/**
- * Returns the null map size in bytes if there are nullable elements, zero
otherwise.
+ * Get offset of the byte that contains null-bit of a given tuple element.
+ *
+ * @param index Tuple element index.
+ * @return Offset of the required byte relative to the tuple start.
+ */
+ public static int getNullOffset(int index) {
Review Comment:
Perhaps the current name is not very good. But I think `nullByteOffset`
would be confusing. People could misread it as "Offset of a null byte" and
wrongfully think that this is about some byte with zero value. So to be
entirely clear it should be something like `byteOffsetOfNullBitOctet`. What do
you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
