korlov42 commented on code in PR #965:
URL: https://github.com/apache/ignite-3/pull/965#discussion_r937692418
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTupleSchema.java:
##########
@@ -289,10 +289,23 @@ public static int nullMapSize(int numElements) {
}
/**
- * Returns the null map size in bytes if there are nullable elements, zero
otherwise.
+ * Get offset of the byte that contains null-bit of a given tuple element.
Review Comment:
Well, this is more like suggestion.
The reasons I prefer "Returns" over "Gets" are follow:
- with "Returns" it sounds more natural to me
- built in java library uses "Returns" instead of "Gets" (please take a look
at any class/interface at java.util package, for instance; honesty speaking,
I've never seen "Gets" anywhere but in ignite codebase)
- "Returns" is imperative as well
Once again, it's just a suggestion. Feel free to ignore this (then just
resolve the conversation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
