tkalkirill commented on code in PR #976:
URL: https://github.com/apache/ignite-3/pull/976#discussion_r938612266
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/VolatilePageMemoryDataRegion.java:
##########
@@ -104,60 +103,43 @@ public void start() {
}
private TableFreeList createTableFreeList(PageMemory pageMemory) throws
IgniteInternalCheckedException {
- long metaPageId = pageMemory.allocatePage(FREE_LIST_GROUP_ID,
FREE_LIST_PARTITION_ID, FLAG_AUX);
-
return new TableFreeList(
FREE_LIST_GROUP_ID,
FREE_LIST_PARTITION_ID,
pageMemory,
PageLockListenerNoOp.INSTANCE,
- metaPageId,
+ pageMemory.allocatePage(FREE_LIST_GROUP_ID,
FREE_LIST_PARTITION_ID, FLAG_AUX),
true,
- null,
PageEvictionTrackerNoOp.INSTANCE,
IoStatisticsHolderNoOp.INSTANCE
);
}
- private static VersionChainFreeList createVersionChainFreeList(
- PageMemory pageMemory,
- ReuseList reuseList
- ) throws IgniteInternalCheckedException {
- long metaPageId = pageMemory.allocatePage(FREE_LIST_GROUP_ID,
FREE_LIST_PARTITION_ID, FLAG_AUX);
-
+ private static VersionChainFreeList createVersionChainFreeList(PageMemory
pageMemory) throws IgniteInternalCheckedException {
return new VersionChainFreeList(
FREE_LIST_GROUP_ID,
FREE_LIST_PARTITION_ID,
pageMemory,
- reuseList,
PageLockListenerNoOp.INSTANCE,
- metaPageId,
+ pageMemory.allocatePage(FREE_LIST_GROUP_ID,
FREE_LIST_PARTITION_ID, FLAG_AUX),
true,
- null,
PageEvictionTrackerNoOp.INSTANCE,
IoStatisticsHolderNoOp.INSTANCE
);
}
private static RowVersionFreeList createRowVersionFreeList(
PageMemory pageMemory,
- ReuseList reuseList
+ VersionChainFreeList reuseList
) throws IgniteInternalCheckedException {
- long metaPageId = pageMemory.allocatePage(
- FREE_LIST_GROUP_ID,
- FREE_LIST_PARTITION_ID,
- FLAG_AUX
- );
-
return new RowVersionFreeList(
FREE_LIST_GROUP_ID,
FREE_LIST_PARTITION_ID,
pageMemory,
reuseList,
PageLockListenerNoOp.INSTANCE,
- metaPageId,
+ pageMemory.allocatePage(FREE_LIST_GROUP_ID,
FREE_LIST_PARTITION_ID, FLAG_AUX),
Review Comment:
Fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
