sashapolo commented on code in PR #979:
URL: https://github.com/apache/ignite-3/pull/979#discussion_r938641534
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/index/IndexRow.java:
##########
@@ -17,26 +17,26 @@
package org.apache.ignite.internal.storage.index;
-import org.apache.ignite.internal.storage.PartitionStorage;
-import org.apache.ignite.internal.storage.SearchRow;
+import java.nio.ByteBuffer;
+import org.apache.ignite.internal.storage.MvPartitionStorage;
+import org.apache.ignite.internal.storage.RowId;
/**
- * Represents an Index Row - a set of indexed columns and Primary Key columns
(for key uniqueness).
+ * Represents an Index Row - a set of indexed columns and a corresponding Row
ID.
*/
public interface IndexRow {
/**
- * Returns the serialized presentation of this row as a byte array.
+ * Returns the serialized presentation of indexed columns as a byte array
in
+ * <a
href="https://cwiki.apache.org/confluence/display/IGNITE/IEP-92%3A+Binary+Tuple+Format";>IEP-92</a>
format.
*
* @return Serialized byte array value.
*/
- byte[] rowBytes();
+ ByteBuffer indexBytes();
Review Comment:
Because it is impossible to deserialize an `InternalTuple`, while a
`ByteBuffer` can be wrapped into a `BinaryTuple`. Returning a `BinaryTuple`
might be a good alternative, but I'm not sure if it's actually better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
