SammyVimes commented on code in PR #953: URL: https://github.com/apache/ignite-3/pull/953#discussion_r938659980
########## modules/cli/src/test/java/org/apache/ignite/cli/core/repl/completer/DynamicCompleterFilterTest.java: ########## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.cli.core.repl.completer; + +import static java.util.Arrays.asList; +import static org.hamcrest.MatcherAssert.assertThat; +import static org.hamcrest.Matchers.containsInAnyOrder; + +import org.apache.ignite.cli.core.repl.Session; +import org.junit.jupiter.api.Test; + +class DynamicCompleterFilterTest { + + @Test + void filtersHelp() { + // Given + String[] words = new String[]{"cluster", "config", "show", ""}; + // And completion candidates + String[] candidates = new String[]{"--selector", "--cluster-url", "--help", "-h"}; + // And user is not connected to the cluster + Session session = notConnected(); + + // When + String[] filtered = new DynamicCompleterFilter(session).filter(words, candidates); + + // Then help is filtered out + assertThat(asList(filtered), containsInAnyOrder("--selector", "--cluster-url")); + } + + private static Session notConnected() { + Session session = new Session(); + session.setConnectedToNode(false); + return session; + } + + private static Session connected() { + Session session = new Session(); + session.setConnectedToNode(true); + return session; + } + + @Test + void doesNotFiltersHelpIfOptionIsTyped() { + // Given typed words that end with "-" + String[] words = new String[]{"cluster", "config", "show", "-"}; + // And completion candidates + String[] candidates = new String[]{"--selector", "--cluster-url", "--help", "-h"}; + // And user is not connected to the cluster + Session session = notConnected(); + + // When + String[] filtered = new DynamicCompleterFilter(session).filter(words, candidates); + + // Then help is NOT filtered out + assertThat(asList(filtered), containsInAnyOrder("--selector", "--cluster-url", "--help", "-h")); + } + + @Test + void filtersClusterUrlWhenConnected() { + // Given typed words that end with "-" + String[] words = new String[]{"cluster", "config", "show", ""}; + // And completion candidates + String[] candidates = new String[]{"--selector", "--cluster-url", "--help", "-h"}; + // And + Session session = connected(); + + // When + String[] filtered = new DynamicCompleterFilter(session).filter(words, candidates); + + // Then cluster-url and help are filtered out + assertThat(asList(filtered), containsInAnyOrder("--selector")); + } + + @Test + void doesNotFiltersHelpIfOptionIsTypedAndConnected() { Review Comment: ```suggestion void doesNotFilterHelpIfOptionIsTypedAndConnected() { ``` ########## modules/cli/src/test/java/org/apache/ignite/cli/core/repl/completer/DynamicCompleterFilterTest.java: ########## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.cli.core.repl.completer; + +import static java.util.Arrays.asList; +import static org.hamcrest.MatcherAssert.assertThat; +import static org.hamcrest.Matchers.containsInAnyOrder; + +import org.apache.ignite.cli.core.repl.Session; +import org.junit.jupiter.api.Test; + +class DynamicCompleterFilterTest { + + @Test + void filtersHelp() { + // Given + String[] words = new String[]{"cluster", "config", "show", ""}; + // And completion candidates + String[] candidates = new String[]{"--selector", "--cluster-url", "--help", "-h"}; + // And user is not connected to the cluster + Session session = notConnected(); + + // When + String[] filtered = new DynamicCompleterFilter(session).filter(words, candidates); + + // Then help is filtered out + assertThat(asList(filtered), containsInAnyOrder("--selector", "--cluster-url")); + } + + private static Session notConnected() { + Session session = new Session(); + session.setConnectedToNode(false); + return session; + } + + private static Session connected() { + Session session = new Session(); + session.setConnectedToNode(true); + return session; + } + + @Test + void doesNotFiltersHelpIfOptionIsTyped() { Review Comment: ```suggestion void doesNotFilterHelpIfOptionIsTyped() { ``` ########## modules/cli/src/main/java/org/apache/ignite/cli/core/repl/completer/HoconDynamicCompleter.java: ########## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.cli.core.repl.completer; + +import com.typesafe.config.Config; +import java.util.ArrayList; +import java.util.List; +import java.util.Map.Entry; +import java.util.Set; +import java.util.stream.Collectors; + +/** + * Completes typed words with hocon schema keys. + */ +public class HoconDynamicCompleter implements DynamicCompleter { + + private final Config config; + + /** Stores all keys that exist in the given config. Strings are stored in format: "root.subkey.subsubkey". */ + private final Set<String> leafs; + + /** List of all possible completions. */ + private final List<String> completions; + + /** Words, after those the completer should have been activated. */ + private final Set<String> activationPostfixes; + + /** Default constructor that created an instance from given set of postfixes after those the completion is expected. */ Review Comment: ```suggestion /** Default constructor that creates an instance from a given set of postfixes that trigger the completion. */ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
