ibessonov commented on code in PR #979:
URL: https://github.com/apache/ignite-3/pull/979#discussion_r940049315
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/index/IndexRow.java:
##########
@@ -26,12 +26,12 @@
*/
public interface IndexRow {
/**
- * Returns the serialized presentation of indexed columns as a byte array
in
+ * Returns the serialized presentation of indexed columns as a {@link
BinaryTuple} in
* <a
href="https://cwiki.apache.org/confluence/display/IGNITE/IEP-92%3A+Binary+Tuple+Format";>IEP-92</a>
format.
*
- * @return Serialized byte array value.
+ * @return Binary tuple representation of indexed columns.
*/
- ByteBuffer indexBytes();
+ BinaryTuple indexColumns();
Review Comment:
I wonder why it's a BinaryTuple instead of InternalTuple. Maybe we don't
even need an interface, only the implementation? Maybe we should remove it in
the future, idk
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/index/IndexRow.java:
##########
@@ -26,12 +26,12 @@
*/
public interface IndexRow {
/**
- * Returns the serialized presentation of indexed columns as a byte array
in
+ * Returns the serialized presentation of indexed columns as a {@link
BinaryTuple} in
* <a
href="https://cwiki.apache.org/confluence/display/IGNITE/IEP-92%3A+Binary+Tuple+Format";>IEP-92</a>
format.
*
- * @return Serialized byte array value.
+ * @return Binary tuple representation of indexed columns.
*/
- ByteBuffer indexBytes();
+ BinaryTuple indexColumns();
Review Comment:
You see, the problem with BinaryTuple is that it contains its own schema for
no good reason.
Well, there is a reason, but it's artificial and can be worked around
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
