tkalkirill commented on code in PR #939: URL: https://github.com/apache/ignite-3/pull/939#discussion_r940913404
########## modules/raft/src/main/java/org/apache/ignite/raft/jraft/storage/impl/LogStorageOverflowException.java: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.raft.jraft.storage.impl; + +import org.apache.ignite.lang.IgniteException; + +/** + * Thrown by {@link org.apache.ignite.raft.jraft.storage.LogStorage} methods to indicate that some entries (a suffix of the + * collection of entries that was tried to be saved) were not saved due to an overflow. + */ +public class LogStorageOverflowException extends IgniteException { + private final int overflowedEntries; + + /** + * Constructs new instance. + * + * @param overflowedEntries Length of the suffix that was not saved. + */ + public LogStorageOverflowException(int overflowedEntries) { + super(overflowedEntries + " entries were not saved due to log storage overflow"); + + this.overflowedEntries = overflowedEntries; + } + + /** + * Returns number of entries that were not saved in the current attempt to append entries. + * + * @return Number of entries that were not saved in the current attempt to append entries. Review Comment: In 2.0 it was definitely required, in 3.0 it is not necessary so this is a suggestion and not a remark. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
