anton-vinogradov commented on code in PR #10157:
URL: https://github.com/apache/ignite/pull/10157#discussion_r942476422
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/eviction/paged/PageEvictionPagesRecyclingAndReusingTest.java:
##########
@@ -107,15 +91,6 @@ public void testPagesRecyclingAndReusingMvccTxReplicated()
throws Exception {
testPagesRecyclingAndReusing(CacheAtomicityMode.TRANSACTIONAL_SNAPSHOT,
CacheMode.REPLICATED);
}
- /**
- * @throws Exception If failed.
- */
-
@Ignore("https://issues.apache.org/jira/browse/IGNITE-7956,https://issues.apache.org/jira/browse/IGNITE-9530";)
Review Comment:
Can be resolved?
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheConcurrentMapSelfTest.java:
##########
@@ -1,339 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.ignite.internal.processors.cache;
-
-import java.util.HashMap;
-import java.util.Iterator;
-import java.util.Map;
-import java.util.Random;
-import java.util.concurrent.Callable;
-import java.util.concurrent.atomic.AtomicInteger;
-import javax.cache.Cache;
-import org.apache.ignite.IgniteCache;
-import org.apache.ignite.configuration.CacheConfiguration;
-import org.apache.ignite.configuration.IgniteConfiguration;
-import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
-import org.junit.Test;
-
-import static org.apache.ignite.cache.CacheMode.LOCAL;
-import static org.apache.ignite.cache.CacheWriteSynchronizationMode.FULL_SYNC;
-
-/**
- * Grid cache concurrent hash map self test.
- */
-public class GridCacheConcurrentMapSelfTest extends GridCommonAbstractTest {
Review Comment:
Could be refactored instead of removal?
##########
modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheOffheapIndexScanTest.java:
##########
@@ -1,184 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.ignite.internal.processors.cache;
-
-import java.io.Serializable;
-import java.util.concurrent.Callable;
-import java.util.concurrent.atomic.AtomicBoolean;
-import org.apache.ignite.IgniteCache;
-import org.apache.ignite.cache.query.SqlFieldsQuery;
-import org.apache.ignite.cache.query.annotations.QuerySqlField;
-import org.apache.ignite.configuration.CacheConfiguration;
-import org.apache.ignite.configuration.IgniteConfiguration;
-import org.apache.ignite.internal.IgniteInternalFuture;
-import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
-import org.junit.Test;
-
-import static org.apache.ignite.cache.CacheMode.LOCAL;
-
-/**
- * Based scanCount with offheap index issue.
- */
-public class IgniteCacheOffheapIndexScanTest extends GridCommonAbstractTest {
Review Comment:
Could this be refactored instead or removal?
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheOnCopyFlagLocalSelfTest.java:
##########
@@ -1,41 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.ignite.internal.processors.cache;
-
-import org.apache.ignite.cache.CacheAtomicityMode;
-import org.apache.ignite.cache.CacheMode;
-import org.junit.Ignore;
-
-import static org.apache.ignite.cache.CacheAtomicityMode.ATOMIC;
-import static org.apache.ignite.cache.CacheMode.LOCAL;
-
-/**
- * Tests {@link org.apache.ignite.cache.CacheInterceptor}.
- */
-@Ignore("https://issues.apache.org/jira/browse/IGNITE-9214";)
Review Comment:
Could be resolved?
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/expiry/IgniteCacheAtomicLocalOnheapExpiryPolicyTest.java:
##########
@@ -1,32 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-
-package org.apache.ignite.internal.processors.cache.expiry;
-
-import org.junit.Ignore;
-
-/**
- *
- */
-@Ignore("https://issues.apache.org/jira/browse/IGNITE-9214";)
Review Comment:
Could be resolved?
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/datastructures/IgniteDataStructuresTestUtils.java:
##########
@@ -104,11 +99,6 @@ public static Map<String, CollectionConfiguration>
getCollectionConfigurations()
for (CacheAtomicityMode atomicityMode :
Arrays.asList(TRANSACTIONAL, ATOMIC)) {
for (int backups : Arrays.asList(0, 1)) {
for (CacheMode cacheMode : CacheMode.values()) {
- if (cacheMode == CacheMode.LOCAL) {
- // TODO:
https://issues.apache.org/jira/browse/IGNITE-13076
Review Comment:
Please don't forget to resolve all unmentioned issues.
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheConfigurationConsistencySelfTest.java:
##########
@@ -140,7 +138,7 @@ public void testCacheUtilsCheckAttributeMismatch() throws
Exception {
final GridStringLogger strLog = new GridStringLogger(false, log);
- CU.checkAttributeMismatch(strLog, "cache", node.id(), "cacheMode",
"Cache mode", LOCAL, PARTITIONED, false);
+ CU.checkAttributeMismatch(strLog, "cache", node.id(), "cacheMode",
"Cache mode", REPLICATED, PARTITIONED, false);
Review Comment:
Looks like incorrect fix.
This method check local and real caches configs and should be removed?
##########
modules/core/src/main/java/org/apache/ignite/internal/jdbc2/JdbcBatchUpdateTask.java:
##########
@@ -119,7 +119,7 @@ public JdbcBatchUpdateTask(Ignite ignite, String cacheName,
String schemaName, S
boolean start = ignite.configuration().isClientMode();
if (cache == null && cacheName == null)
- cache =
((IgniteKernal)ignite).context().cache().getOrStartPublicCache(start, !loc &&
locQry);
+ cache =
((IgniteKernal)ignite).context().cache().getOrStartPublicCache(start);
Review Comment:
Please remove the flag fields as well
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteAbstractTxSuspendResumeTest.java:
##########
@@ -223,11 +221,6 @@ public void testResumeTxInAnotherThread() throws Exception
{
public void testCrossCacheTxInAnotherThread() throws Exception {
executeTestForAllCaches(new CI2Exc<Ignite, IgniteCache<Integer,
Integer>>() {
@Override public void applyx(Ignite ignite, final
IgniteCache<Integer, Integer> cache) throws Exception {
- // TODO: IGNITE-9110 Optimistic tx hangs in cross-cache
operations with LOCAL and non LOCAL caches.
Review Comment:
Don't forget to resolve
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/eviction/paged/PageEvictionReadThroughTest.java:
##########
@@ -91,16 +75,6 @@ public void testEvictionWithReadThroughMvccTxPartitioned()
throws Exception {
testEvictionWithReadThrough(CacheAtomicityMode.TRANSACTIONAL_SNAPSHOT,
CacheMode.PARTITIONED);
}
- /**
- * @throws Exception If failed.
- */
-
@Ignore("https://issues.apache.org/jira/browse/IGNITE-8582,https://issues.apache.org/jira/browse/IGNITE-7956,";
- + "https://issues.apache.org/jira/browse/IGNITE-9530";)
Review Comment:
Can be resolved?
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/eviction/GridCacheConcurrentEvictionConsistencySelfTest.java:
##########
@@ -1,362 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.ignite.internal.processors.cache.eviction;
-
-import java.util.Collection;
-import java.util.Collections;
-import java.util.Random;
-import java.util.concurrent.Callable;
-import javax.cache.Cache;
-import org.apache.ignite.Ignite;
-import org.apache.ignite.IgniteCache;
-import org.apache.ignite.cache.CachePeekMode;
-import org.apache.ignite.cache.eviction.EvictableEntry;
-import org.apache.ignite.cache.eviction.EvictionPolicy;
-import org.apache.ignite.cache.eviction.fifo.FifoEvictionPolicy;
-import org.apache.ignite.cache.eviction.lru.LruEvictionPolicy;
-import org.apache.ignite.cache.eviction.sorted.SortedEvictionPolicy;
-import org.apache.ignite.configuration.CacheConfiguration;
-import org.apache.ignite.configuration.IgniteConfiguration;
-import org.apache.ignite.internal.IgniteInternalFuture;
-import org.apache.ignite.internal.processors.cache.CacheEvictableEntryImpl;
-import org.apache.ignite.internal.util.typedef.internal.U;
-import org.apache.ignite.testframework.MvccFeatureChecker;
-import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
-import org.apache.ignite.transactions.Transaction;
-import org.junit.Test;
-
-import static org.apache.ignite.cache.CacheMode.LOCAL;
-import static org.apache.ignite.cache.CacheWriteSynchronizationMode.FULL_SYNC;
-import static
org.apache.ignite.transactions.TransactionConcurrency.PESSIMISTIC;
-import static
org.apache.ignite.transactions.TransactionIsolation.REPEATABLE_READ;
-
-/**
- *
- */
-public class GridCacheConcurrentEvictionConsistencySelfTest extends
GridCommonAbstractTest {
- /** Default iteration count. */
- private static final int ITERATION_CNT = 50000;
-
- /** Size of policy internal queue. */
- private static final int POLICY_QUEUE_SIZE = 50;
-
- /** Tested policy. */
- private EvictionPolicy<?, ?> plc;
-
- /** Key count to put into the cache. */
- private int keyCnt;
-
- /** Number of threads. */
- private int threadCnt = Runtime.getRuntime().availableProcessors();
-
- /** {@inheritDoc} */
- @Override protected IgniteConfiguration getConfiguration(String
igniteInstanceName) throws Exception {
-
MvccFeatureChecker.skipIfNotSupported(MvccFeatureChecker.Feature.LOCAL_CACHE);
-
- IgniteConfiguration c = super.getConfiguration(igniteInstanceName);
-
- c.getTransactionConfiguration().setDefaultTxConcurrency(PESSIMISTIC);
- c.getTransactionConfiguration().setDefaultTxIsolation(REPEATABLE_READ);
-
- CacheConfiguration cc = defaultCacheConfiguration();
-
- cc.setCacheMode(LOCAL);
Review Comment:
Mode should be replaced with partitioned instead or test removal?
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/local/GridCacheFastNodeLeftForTransactionTest.java:
##########
@@ -1,338 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.ignite.internal.processors.cache.local;
-
-import java.util.ArrayList;
-import java.util.Collection;
-import java.util.List;
-import java.util.Map;
-import java.util.concurrent.atomic.AtomicReference;
-import org.apache.ignite.IgniteCache;
-import org.apache.ignite.IgniteLogger;
-import org.apache.ignite.cache.CacheWriteSynchronizationMode;
-import org.apache.ignite.cache.affinity.rendezvous.RendezvousAffinityFunction;
-import org.apache.ignite.configuration.CacheConfiguration;
-import org.apache.ignite.configuration.ConnectorConfiguration;
-import org.apache.ignite.configuration.IgniteConfiguration;
-import org.apache.ignite.internal.IgniteEx;
-import
org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxFinishFuture;
-import
org.apache.ignite.internal.processors.cache.transactions.TransactionProxyImpl;
-import org.apache.ignite.internal.processors.cache.verify.IdleVerifyResultV2;
-import org.apache.ignite.internal.util.typedef.internal.SB;
-import org.apache.ignite.testframework.GridTestUtils;
-import org.apache.ignite.testframework.ListeningTestLogger;
-import org.apache.ignite.testframework.LogListener;
-import org.apache.ignite.testframework.junits.GridAbstractTest;
-import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
-import org.apache.ignite.transactions.Transaction;
-import org.junit.Test;
-
-import static java.util.Objects.nonNull;
-import static java.util.function.Function.identity;
-import static java.util.stream.Collectors.toList;
-import static java.util.stream.Collectors.toMap;
-import static java.util.stream.IntStream.range;
-import static org.apache.ignite.cache.CacheAtomicityMode.TRANSACTIONAL;
-import static org.apache.ignite.cache.CacheWriteSynchronizationMode.FULL_SYNC;
-import static
org.apache.ignite.cache.CacheWriteSynchronizationMode.PRIMARY_SYNC;
-import static org.apache.ignite.testframework.GridTestUtils.assertContains;
-import static org.apache.ignite.testframework.GridTestUtils.getFieldValue;
-import static org.apache.ignite.testframework.GridTestUtils.setFieldValue;
-import static org.apache.ignite.testframework.LogListener.matches;
-
-/**
- * Class for testing fast node left during transaction for cache.
- */
-public class GridCacheFastNodeLeftForTransactionTest extends
GridCommonAbstractTest {
Review Comment:
Any reason to remove this test?
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/IgnitePdsDestroyCacheAbstractTest.java:
##########
@@ -78,7 +76,6 @@ public abstract class IgnitePdsDestroyCacheAbstractTest
extends GridCommonAbstra
/**
* @param ignite Ignite.
- * @param singlePart {@code True} to load data to single partition.
Review Comment:
Why removed?
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheSlowTxWarnTest.java:
##########
@@ -55,10 +51,7 @@ public class GridCacheSlowTxWarnTest extends
GridCommonAbstractTest {
CacheConfiguration cc3 = defaultCacheConfiguration();
Review Comment:
Should be removed as well
##########
modules/core/src/test/java/org/apache/ignite/testframework/MvccFeatureChecker.java:
##########
@@ -163,9 +148,6 @@ private static String unsupportedReason(Feature feature) {
case NEAR_CACHE:
return "https://issues.apache.org/jira/browse/IGNITE-7187";;
- case LOCAL_CACHE:
- return "https://issues.apache.org/jira/browse/IGNITE-9530";;
Review Comment:
Could this be resolved?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
