ygerzhedovich commented on code in PR #990:
URL: https://github.com/apache/ignite-3/pull/990#discussion_r947872373
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlAsynchronousApiTest.java:
##########
@@ -313,10 +314,12 @@ public void checkTransactionsWithDml() throws Exception {
checkDml(2 * ROW_COUNT, ses, "DELETE FROM TEST WHERE VAL0 >= 0");
- assertEquals(ROW_COUNT + 1 + 1 + 1 + 1, txManagerInternal.finished() -
txPrevCnt);
+ assertEquals(ROW_COUNT + 1 + 1 + 1 + 1 + 1,
txManagerInternal.finished() - txPrevCnt);
var states = (Map<UUID, TxState>)
IgniteTestUtils.getFieldValue(txManagerInternal, TxManagerImpl.class, "states");
+ assertTrue(waitForCondition(() -> states.values().stream().noneMatch(e
-> e.equals(TxState.PENDING)), 5_000));
Review Comment:
I don't understand why a transaction could be in a PENDING STATE here. Could
you please elaborate this? Also even if so true the next assert looks strange.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
