alex-plekhanov commented on code in PR #10175:
URL: https://github.com/apache/ignite/pull/10175#discussion_r948041396
##########
modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/stat/StatisticsGatheringTest.java:
##########
@@ -117,8 +117,10 @@ private static void testEquaData(ObjectStatisticsImpl
expected, ObjectStatistics
ColumnStatistics actColStat =
actual.columnStatistics(expectedColStatEntry.getKey());
assertNotNull(actColStat);
- assertEquals(expColStat.min(), actColStat.min());
- assertEquals(expColStat.max(), actColStat.max());
+ assertEquals(expColStat.min() != null ? expColStat.min() : null,
Review Comment:
Redundant change, `expColStat.min() != null ? expColStat.min() : null` can
be simplified to `expColStat.min()`
##########
modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/stat/StatisticsViewsTest.java:
##########
@@ -56,21 +52,13 @@ public abstract class StatisticsViewsTest extends
StatisticsAbstractTest {
*/
@Test
public void testConfigurationView() throws Exception {
- collectStatistics(StatisticsType.GLOBAL, SMALL_TARGET);
-
- ObjectStatisticsImpl smallStat =
(ObjectStatisticsImpl)statisticsMgr(0).getLocalStatistics(SMALL_KEY);
-
- long aVer = smallStat.columnStatistics("A").version();
- long bVer = smallStat.columnStatistics("B").version();
- long cVer = smallStat.columnStatistics("C").version();
-
List<List<Object>> config = Arrays.asList(
- Arrays.asList(SCHEMA, "TABLE", "SMALL", "A", (byte)15, null, null,
null, null, aVer),
- Arrays.asList(SCHEMA, "TABLE", "SMALL", "B", (byte)15, null, null,
null, null, bVer),
- Arrays.asList(SCHEMA, "TABLE", "SMALL", "C", (byte)15, null, null,
null, null, cVer)
+ Arrays.asList(SCHEMA, "TABLE", "SMALL", "A", (byte)15, null, null,
null, null, 1L),
Review Comment:
If this test will be executed after testEnforceStatisticValues - there will
be undeleted data and test will fail.
##########
modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/stat/StatisticsViewsTest.java:
##########
@@ -56,21 +52,13 @@ public abstract class StatisticsViewsTest extends
StatisticsAbstractTest {
*/
@Test
public void testConfigurationView() throws Exception {
Review Comment:
Please remove redundant NL before this method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
