SammyVimes commented on code in PR #1023:
URL: https://github.com/apache/ignite-3/pull/1023#discussion_r950137154
##########
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/storage/ConfigurationStorage.java:
##########
@@ -27,11 +27,11 @@
*/
public interface ConfigurationStorage extends AutoCloseable {
/**
- * Read all configuration values and current storage version.
+ * Reads all configuration values and current storage version on the start.
Review Comment:
As I understand, it only makes sense on the start (and it's only called on
the start). It does some additional stuff like deciding what revision to use
##########
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/storage/ConfigurationStorage.java:
##########
@@ -27,11 +27,11 @@
*/
public interface ConfigurationStorage extends AutoCloseable {
/**
- * Read all configuration values and current storage version.
+ * Reads all configuration values and current storage version on the start.
Review Comment:
As I understand, it only makes sense on the start (and it's only called on
the start). It does some additional stuff like deciding what revision to use,
it only makes sense on recovery
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
