sashapolo commented on code in PR #1023:
URL: https://github.com/apache/ignite-3/pull/1023#discussion_r950280506
##########
modules/runner/src/main/java/org/apache/ignite/internal/configuration/storage/DistributedConfigurationStorage.java:
##########
@@ -185,39 +190,54 @@ public CompletableFuture<Serializable> readLatest(String
key) {
/** {@inheritDoc} */
@Override
- public CompletableFuture<Data> readAll() throws StorageException {
+ public CompletableFuture<Data> readDataOnRecovery() throws
StorageException {
return registerFuture(vaultMgr.get(MetaStorageManager.APPLIED_REV)
- .thenApplyAsync(appliedRevEntry -> {
- long appliedRevision = appliedRevEntry == null ? 0L :
ByteUtils.bytesToLong(appliedRevEntry.value());
+ .thenCombineAsync(vaultMgr.get(CONFIGURATION_REVISIONS_KEY),
this::readAllOnStart0, threadPool));
+ }
+
+ @NotNull
+ private Data readAllOnStart0(VaultEntry appliedRevEntry, VaultEntry
revisionsEntry) {
Review Comment:
1. Parameters should be marked with `@Nullable`
2. We don't use `@NotNull`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
