ygerzhedovich commented on code in PR #1004:
URL: https://github.com/apache/ignite-3/pull/1004#discussion_r955015167
##########
modules/api/src/main/java/org/apache/ignite/sql/Session.java:
##########
@@ -215,12 +215,20 @@ default long[] executeBatch(@Nullable Transaction
transaction, String dmlQuery,
CompletableFuture<Void> executeScriptAsync(String query, @Nullable
Object... arguments);
/**
- * Return default query timeout.
+ * Return default query timeout which bound query execution time. In case
a query take more time it's will be interrupted.
*
* @param timeUnit Timeunit to convert timeout to.
* @return Default query timeout in the given timeunit.
*/
- long defaultTimeout(TimeUnit timeUnit);
+ long defaultQueryTimeout(TimeUnit timeUnit);
+
+ /**
+ * Return default idle session timeout. The duration after which the
session will be considered expired if no one use it.
+ *
+ * @param timeUnit Timeunit to convert timeout to.
+ * @return Default session timeout in the given timeunit.
+ */
+ long defaultIdleSessionTimeout(TimeUnit timeUnit);
Review Comment:
we have all parameters in the class as `default*` Why do you think that for
the case should be different naming practice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
