ivandasch commented on code in PR #10213:
URL: https://github.com/apache/ignite/pull/10213#discussion_r955955764
##########
modules/core/src/main/java/org/apache/ignite/internal/visor/consistency/VisorConsistencyRepairTask.java:
##########
@@ -117,73 +125,84 @@ protected
VisorConsistencyRepairJob(VisorConsistencyRepairTaskArg arg, boolean d
log.info("Consistency check started " +
"[grp=" + grpCtx.cacheOrGroupName() + ", part=" + p + ",
strategy=" + strategy + "]");
- StringBuilder sb = new StringBuilder();
-
- sb.append("[node=").append(ignite.localNode());
- sb.append(", cacheGroup=").append(grpCtx.cacheOrGroupName());
- sb.append(", part=").append(p).append("]");
-
- String statusKey = sb.toString();
+ String statusKey = "[node=" + ignite.localNode() + ", cacheGroup="
+ grpCtx.cacheOrGroupName() + ", part=" + p + "]";
if (VisorConsistencyStatusTask.MAP.putIfAbsent(statusKey, "0/" +
part.fullSize()) != null)
Review Comment:
This isn't an one-liner conditional branch, so it should be in curly braces
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
