korlov42 commented on code in PR #990:
URL: https://github.com/apache/ignite-3/pull/990#discussion_r956163454
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlAsynchronousApiTest.java:
##########
@@ -592,13 +591,15 @@ public void batchIncomplete() {
}
}
- Throwable ex = assertThrowsWithCause(
- () -> ses.executeBatchAsync(null, "INSERT INTO TEST VALUES (?,
?)", args).join(),
- SqlBatchException.class
+ CompletionException ex = assertThrows(
Review Comment:
This is not an option because `assertThrows` verifies the topmost exception
only. `CompletionException` in this particular case is caused by `join()`
within the closure rather then by internals of sql engine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
