ibessonov commented on code in PR #1038:
URL: https://github.com/apache/ignite-3/pull/1038#discussion_r957393522
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/RowVersion.java:
##########
@@ -17,41 +17,39 @@
package org.apache.ignite.internal.storage.pagememory.mv;
+import static org.apache.ignite.hlc.HybridTimestamp.HYBRID_TIMESTAMP_SIZE;
+
import java.nio.ByteBuffer;
import java.util.Objects;
+import org.apache.ignite.hlc.HybridTimestamp;
import org.apache.ignite.internal.pagememory.Storable;
import org.apache.ignite.internal.pagememory.io.AbstractDataPageIo;
import org.apache.ignite.internal.pagememory.io.IoVersions;
import org.apache.ignite.internal.storage.pagememory.mv.io.RowVersionDataIo;
import org.apache.ignite.internal.tostring.IgniteToStringExclude;
import org.apache.ignite.internal.tostring.S;
-import org.apache.ignite.internal.tx.Timestamp;
import org.jetbrains.annotations.Nullable;
/**
* Represents row version inside row version chain.
*/
-public class RowVersion implements Storable {
- /** A 'timestamp' representing absense of a timestamp. */
- public static final Timestamp NULL_TIMESTAMP = new
Timestamp(Long.MIN_VALUE, Long.MIN_VALUE);
-
+public final class RowVersion implements Storable {
/** Represents an absent partitionless link. */
public static final long NULL_LINK = 0;
- private static final int TIMESTAMP_STORE_SIZE_BYTES = 2 * Long.BYTES;
private static final int NEXT_LINK_STORE_SIZE_BYTES =
PartitionlessLinks.PARTITIONLESS_LINK_SIZE_BYTES;
private static final int VALUE_SIZE_STORE_SIZE_BYTES = Integer.BYTES;
public static final int TIMESTAMP_OFFSET = 0;
- public static final int NEXT_LINK_OFFSET = TIMESTAMP_STORE_SIZE_BYTES;
+ public static final int NEXT_LINK_OFFSET = HYBRID_TIMESTAMP_SIZE;
Review Comment:
Makes sense, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
