ibessonov commented on code in PR #1021: URL: https://github.com/apache/ignite-3/pull/1021#discussion_r959364649
########## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/freelist/IndexColumns.java: ########## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.storage.pagememory.index.freelist; + +import static org.apache.ignite.internal.pagememory.util.PageIdUtils.NULL_LINK; + +import java.nio.ByteBuffer; +import org.apache.ignite.internal.pagememory.Storable; +import org.apache.ignite.internal.pagememory.io.AbstractDataPageIo; +import org.apache.ignite.internal.pagememory.io.IoVersions; +import org.apache.ignite.internal.storage.pagememory.index.freelist.io.IndexColumnsDataIo; +import org.apache.ignite.lang.IgniteInternalCheckedException; +import org.jetbrains.annotations.Nullable; + +/** + * Index columns to store in free list. + */ +public class IndexColumns implements Storable { + /** Size offset. */ + public static final int SIZE_OFFSET = 0; + + /** Value offset. Value goes right after the size. */ + public static final int VALUE_OFFSET = SIZE_OFFSET + Integer.BYTES; + + /** Partition ID. */ + private final int partitionId; + + /** Link value. */ + private long link = NULL_LINK; + + /** Byte buffer with binary tuple data. */ + private final @Nullable ByteBuffer valueBuffer; + + /** + * Constructor. + * + * @param partitionId Partition ID. + * @param valueBuffer Value buffer. + */ + + public IndexColumns(int partitionId, @Nullable ByteBuffer valueBuffer) { + this.partitionId = partitionId; + this.valueBuffer = valueBuffer; + } + + /** + * Constructor. + * + * @param partitionId Partition ID. + * @param link Link. + * @param valueBuffer Value buffer. + */ + public IndexColumns(int partitionId, long link, @Nullable ByteBuffer valueBuffer) { + this.partitionId = partitionId; + this.link = link; + this.valueBuffer = valueBuffer; + } + + /** + * Returns the size of binary tuple. + */ + public int valueSize() { + assert valueBuffer != null; + + return valueBuffer.limit(); + } + + /** + * Returns a byte buffer that contains binary tuple data. + */ + public ByteBuffer valueBuffer() { + return valueBuffer; Review Comment: Hell no! Array access doesn't work for read-only buffers, making fast or even unsafe access too complicated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
