tkalkirill commented on code in PR #1076:
URL: https://github.com/apache/ignite-3/pull/1076#discussion_r973907866
##########
modules/rocksdb-common/src/main/java/org/apache/ignite/internal/rocksdb/RocksUtils.java:
##########
@@ -83,28 +83,28 @@ public static void checkIterator(RocksIterator it) {
* <p>This method tries to increment the least significant byte (in BE
order) that is not equal to 0xFF (bytes are treated as
* unsigned values).
*
- * @param rangeStart Start of a range of keys (prefix) in RocksDB.
+ * @param array Start of a range of keys (prefix) in RocksDB.
* @return End of a range of keys in RocksDB or {@code null} if all bytes
of the prefix are equal to 0xFF.
*/
- public static byte @Nullable [] rangeEnd(byte[] rangeStart) {
- byte[] rangeEnd = rangeStart.clone();
+ public static byte @Nullable [] incrementArray(byte[] array) {
Review Comment:
```suggestion
public static @Nullable byte[] incrementArray(byte[] array) {
```
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTuplePrefix.java:
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.schema;
+
+import java.math.BigDecimal;
+import java.nio.ByteBuffer;
+import org.apache.ignite.internal.binarytuple.BinaryTuplePrefixBuilder;
+import org.apache.ignite.internal.binarytuple.BinaryTupleReader;
+import org.apache.ignite.internal.schema.row.InternalTuple;
+
+/**
+ * Class that represents a Binary Tuple Prefix.
+ *
+ * @see BinaryTuplePrefixBuilder BinaryTuplePrefixBuilder for information
about the Binary Tuple Prefix format.
+ */
+public class BinaryTuplePrefix extends BinaryTupleReader implements
InternalTuple {
Review Comment:
I think it's better to make it the successor of the BinaryTuple.
In fact, in the SortedIndexStorage, we will also work with BinaryTuple and
not just with prefixes, and this confuses when used.
##########
modules/binary-tuple/src/main/java/org/apache/ignite/internal/binarytuple/BinaryTupleBuilder.java:
##########
@@ -567,6 +554,15 @@ public int elementIndex() {
return elementIndex;
}
+ /**
+ * Gets the expected number of tuple elements.
+ *
+ * @return Expected number of tuple elements.
+ */
Review Comment:
```suggestion
/**
* Gets the expected number of tuple elements.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
