AMashenkov commented on code in PR #1067:
URL: https://github.com/apache/ignite-3/pull/1067#discussion_r975119079
##########
modules/index/src/main/java/org/apache/ignite/internal/index/IndexManager.java:
##########
@@ -87,18 +84,18 @@ public class IndexManager extends Producer<IndexEvent,
IndexEventParameters> imp
*/
public IndexManager(
TableManager tableManager,
- Consumer<ConfigurationNamedListListener<TableIndexView>>
indicesConfigurationChangeSubscription
+ TablesConfiguration tablesCfg
) {
this.tableManager = Objects.requireNonNull(tableManager,
"tableManager");
- this.indicesConfigurationChangeSubscription =
Objects.requireNonNull(indicesConfigurationChangeSubscription,
"tablesConfiguration");
+ this.tablesCfg = Objects.requireNonNull(tablesCfg, "indexesCfg");
}
/** {@inheritDoc} */
@Override
public void start() {
LOG.debug("Index manager is about to start");
- indicesConfigurationChangeSubscription.accept(new
ConfigurationListener());
+ tablesCfg.indexes().listenElements(new ConfigurationListener());
Review Comment:
Slack is not official channel for discussion.
Would you please post the answers\decision here or to dev list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]