ygerzhedovich commented on code in PR #1109:
URL: https://github.com/apache/ignite-3/pull/1109#discussion_r976614161
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/configuration/IndexValidatorImpl.java:
##########
@@ -64,28 +62,77 @@ public void validate(IndexValidator annotation,
ValidationContext<NamedListView<
if (tableView == null) {
ctx.addIssue(new ValidationIssue(key, "Unable to create index
[name=" + key + "]. Table not found."));
+
+ // no further validation required for current index
+ continue;
}
- IndexDefinition index =
SchemaConfigurationConverter.convert(idxView);
+ List<String> colocationColumns;
+ if (tableView.primaryKey() != null) {
Review Comment:
My opion - it can give incorrect unerstanding possibilities of the systems
during read the code. I don'tunderstand why we should care about such case here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
