tkalkirill commented on code in PR #1116:
URL: https://github.com/apache/ignite-3/pull/1116#discussion_r979256720
##########
modules/core/src/main/java/org/apache/ignite/internal/properties/IgniteProductVersion.java:
##########
@@ -29,11 +30,9 @@
*/
public class IgniteProductVersion implements Serializable {
private static final Pattern VERSION_PATTERN =
-
Pattern.compile("(?<major>\\d+)\\.(?<minor>\\d+)\\.(?<maintenance>\\d+)((?<snapshot>-SNAPSHOT)|-(?<alpha>alpha\\d+))?");
+
Pattern.compile("(?<major>\\d+)\\.(?<minor>\\d+)\\.(?<maintenance>\\d+)(\\.(?<patch>\\d+))?(-(?<preRelease>[0-9A-Za-z]+))?");
Review Comment:
According to the [SemVer2](https://semver.org/#spec-item-9) pre release
cannot contain underscores.
##########
modules/core/src/main/java/org/apache/ignite/internal/properties/IgniteProductVersion.java:
##########
@@ -29,11 +30,9 @@
*/
public class IgniteProductVersion implements Serializable {
private static final Pattern VERSION_PATTERN =
-
Pattern.compile("(?<major>\\d+)\\.(?<minor>\\d+)\\.(?<maintenance>\\d+)((?<snapshot>-SNAPSHOT)|-(?<alpha>alpha\\d+))?");
+
Pattern.compile("(?<major>\\d+)\\.(?<minor>\\d+)\\.(?<maintenance>\\d+)(\\.(?<patch>\\d+))?(-(?<preRelease>[0-9A-Za-z]+))?");
Review Comment:
According to the [SemVer2](https://semver.org/#spec-item-9) pre release
cannot contain underscores.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
