kgusakov commented on code in PR #1098:
URL: https://github.com/apache/ignite-3/pull/1098#discussion_r982836132
##########
modules/metrics/src/main/java/org/apache/ignite/internal/metrics/MetricManager.java:
##########
@@ -33,38 +42,61 @@
* Metric manager.
*/
public class MetricManager implements IgniteComponent {
+
+ /** Logger. */
+ private static final IgniteLogger LOG =
Loggers.forClass(MetricManager.class);
+
/**
* Metric registry.
*/
private final MetricRegistry registry;
+ private final MetricProvider metricsProvider;
+
+ private final Map<String, MetricExporter> enabledMetricExporters = new
HashMap<>();
+
/** Metrics' exporters. */
- private List<MetricExporter> metricExporters;
+ private Map<String, MetricExporter> availableExporters;
+
+ private MetricConfiguration metricConfiguration;
Review Comment:
`configure` and `start` has happens-before relations by design and must be
called in sequence. Otherwise, we can start `MetricManager` with null
configuration. In real code - `IgniteImpl` will do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
