Vladsz83 commented on code in PR #10275:
URL: https://github.com/apache/ignite/pull/10275#discussion_r983155770
##########
modules/log4j2/src/test/java/org/apache/ignite/logger/log4j2/Log4j2LoggerSelfTest.java:
##########
@@ -146,6 +146,11 @@ public void testSystemNodeId() throws Exception {
assertEquals(U.id8(id), System.getProperty("nodeId"));
assertEquals("other-app", System.getProperty("appId"));
+
+ new Log4J2Logger(LOG_PATH_TEST).setApplicationAndNode(null, id);
+
+ assertEquals(U.id8(id), System.getProperty("nodeId"));
Review Comment:
`assertEquals(U.id8(id), System.getProperty("nodeId"));` does not faild
witout the fix. ok, might be checked too in same way.
##########
modules/log4j2/src/test/java/org/apache/ignite/logger/log4j2/Log4j2LoggerSelfTest.java:
##########
@@ -146,6 +146,11 @@ public void testSystemNodeId() throws Exception {
assertEquals(U.id8(id), System.getProperty("nodeId"));
assertEquals("other-app", System.getProperty("appId"));
+
+ new Log4J2Logger(LOG_PATH_TEST).setApplicationAndNode(null, id);
+
+ assertEquals(U.id8(id), System.getProperty("nodeId"));
Review Comment:
`assertEquals(U.id8(id), System.getProperty("nodeId"));` does not faild
witout the fix. ok, might be checked in same way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
