SammyVimes commented on code in PR #1124:
URL: https://github.com/apache/ignite-3/pull/1124#discussion_r983910953
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java:
##########
@@ -684,47 +690,24 @@ public void close() throws Exception {
/** {@inheritDoc} */
@Override
public Cursor<BinaryRow> scan(Predicate<BinaryRow> keyFilter, UUID txId)
throws TxIdMismatchException, StorageException {
- return scan(keyFilter, null, txId);
- }
-
- /** {@inheritDoc} */
- @Override
- public Cursor<BinaryRow> scan(Predicate<BinaryRow> keyFilter,
HybridTimestamp timestamp) throws StorageException {
- return scan(keyFilter, timestamp, null);
- }
-
- private Cursor<BinaryRow> scan(Predicate<BinaryRow> keyFilter, @Nullable
HybridTimestamp timestamp, @Nullable UUID txId)
- throws TxIdMismatchException, StorageException {
- assert timestamp == null ^ txId == null;
+ assert txId != null;
// Set next partition as an upper bound.
- var options = new
ReadOptions().setIterateUpperBound(upperBound).setTotalOrderSeek(true);
+ ReadOptions options = new
ReadOptions().setIterateUpperBound(upperBound).setTotalOrderSeek(true);
Review Comment:
We will add it eventually and we do need a total order here. Right now it
just has no effect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
