ptupitsyn commented on code in PR #1139:
URL: https://github.com/apache/ignite-3/pull/1139#discussion_r984266917


##########
modules/platforms/dotnet/Apache.Ignite.Tests/ExceptionsTests.cs:
##########
@@ -52,13 +52,15 @@ public void 
TestExceptionsAreSerializableAndHaveRequiredConstructors()
                 var stream = new MemoryStream();
                 var formatter = new BinaryFormatter();
 
+#pragma warning disable SYSLIB0011 // BinaryFormatter is obsolete

Review Comment:
   Reworked this test to avoid obsolete `BinaryFormatter`.
   
   NOTE: The future of `ISerializable` and related types is not clear, they may 
become obsolete too (see https://github.com/dotnet/runtime/issues/70208). But 
for now we follow existing guidelines and implement this interface properly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to