ygerzhedovich commented on code in PR #1142: URL: https://github.com/apache/ignite-3/pull/1142#discussion_r985734159
########## modules/core/src/test/java/org/apache/ignite/internal/util/IgniteNameUtilsTest.java: ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.util; + +import static org.hamcrest.MatcherAssert.assertThat; +import static org.hamcrest.Matchers.equalTo; +import static org.junit.jupiter.api.Assertions.assertThrows; + +import org.apache.ignite.lang.ErrorGroups.Common; +import org.apache.ignite.lang.IgniteInternalException; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.CsvSource; +import org.junit.jupiter.params.provider.ValueSource; + +/** + * Test cases to verify {@link IgniteNameUtils}. + */ +public class IgniteNameUtilsTest { + @ParameterizedTest + @CsvSource({ + "foo, FOO", "fOo, FOO", "FOO, FOO", "1o0, 1O0", "@#$, @#$", + "\"foo\", foo", "\"fOo\", fOo", "\"f.f\", f.f", "\"f\"\"f\", f\"f", Review Comment: last value doesn't look a valid ########## modules/core/src/testFixtures/java/org/apache/ignite/internal/testframework/IgniteTestUtils.java: ########## @@ -738,13 +737,19 @@ public static <T> T await(CompletionStage<T> stage, long timeout, TimeUnit unit) try { return stage.toCompletableFuture().get(timeout, unit); } catch (Throwable e) { - if (e instanceof ExecutionException) { - e = e.getCause(); - } else if (e instanceof CompletionException) { - e = e.getCause(); + // In tests, we generally interested in original exception, + // rather than ExecutionException generated by the future's + // contract. But topmost frame keeps important information + // about failed operation in clients code. So, let's keep + // this information in a kinda unusual yet sufficient for + // further debug way + Throwable original = ExceptionUtils.unwrapCause(e); + + if (original != e) { + original.addSuppressed(new RuntimeException("This is a trimmed root")); Review Comment: ```suggestion original.addSuppressed(new RuntimeException("This is a trimmed root", e)); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
