zstan commented on code in PR #1134:
URL: https://github.com/apache/ignite-3/pull/1134#discussion_r985789645
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/registry/SchemaRegistryImpl.java:
##########
@@ -86,7 +87,11 @@ public SchemaDescriptor schema(int ver) {
return desc;
}
- desc = history.apply(ver);
+ CompletableFuture<SchemaDescriptor> descFut = history.apply(ver);
+
+ if (descFut != null) {
+ desc = descFut.join();
Review Comment:
yep, this is not mine change, i just move it here ..
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/registry/SchemaRegistryImpl.java:
##########
@@ -86,7 +87,11 @@ public SchemaDescriptor schema(int ver) {
return desc;
}
- desc = history.apply(ver);
+ CompletableFuture<SchemaDescriptor> descFut = history.apply(ver);
+
+ if (descFut != null) {
+ desc = descFut.join();
Review Comment:
yep, this is not mine approach, i just move it here .. if you check previous
code, seems it ok, cause we have a state when no awaiting schema can be
obtained, all we can here - is to wait (i try to treat previous logic )))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
