rpuch commented on code in PR #1169:
URL: https://github.com/apache/ignite-3/pull/1169#discussion_r989351627
##########
modules/network/src/main/java/org/apache/ignite/internal/network/netty/ConnectionManager.java:
##########
@@ -92,6 +92,9 @@ public class ConnectionManager {
/** Recovery descriptor provider. */
private final RecoveryDescriptorProvider descriptorProvider = new
DefaultRecoveryDescriptorProvider();
+ /** An action that is invoked before handshake completes. Only useful for
tests. */
+ private volatile Runnable beforeHandshakeComplete = () -> {};
Review Comment:
`RecoveryClientHandshakeManager` constructor currently requires 5 arguments.
We can pass message factory directly, but we would still need to create a
factory with 4 arguments which makes the factory sooo specific. I'm not sure
whether it's the best way to go, but I'll try and we'll look at the result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
