korlov42 commented on code in PR #1134:
URL: https://github.com/apache/ignite-3/pull/1134#discussion_r994355112
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -1218,58 +1197,28 @@ public CompletableFuture<Void> alterTableAsync(String
name, Consumer<TableChange
}
}
- /** See {@link #alterTableAsync(String, Consumer)} for details. */
- private CompletableFuture<Void> alterTableAsyncInternal(String name,
Consumer<TableChange> tableChange) {
+ /** See {@link #alterTableAsync(String, Predicate)} for details. */
+ private CompletableFuture<Void> alterTableAsyncInternal(String name,
Predicate<TableChange> tableChange) {
Review Comment:
Does it make sense to use `Function<TableChange, Boolean>` instead of
`Predicate<TableChange>`? It may be unexpected that the predicate will change
the passed argument
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
