sashapolo commented on code in PR #1213:
URL: https://github.com/apache/ignite-3/pull/1213#discussion_r997213840
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/hash/io/HashIndexTreeIo.java:
##########
@@ -68,7 +68,7 @@ public interface HashIndexTreeIo {
+ PARTITIONLESS_LINK_SIZE_BYTES // Index columns link.
+ 2 * Long.BYTES; // Row ID.
- /** Index columns are not fully inlined, the index column size is {@link
#indexColumnsInlineSize()}. */
+ /** Special value that is written to the Index Key, indicating the value
has not benn fully inlined into it. */
Review Comment:
```suggestion
/** Special value that is written to the Index Key, indicating the value
has not been fully inlined into it. */
```
##########
modules/storage-page-memory/src/test/java/org/apache/ignite/internal/storage/pagememory/index/AbstractPageMemorySortedIndexStorageTest.java:
##########
@@ -43,6 +45,8 @@
abstract class AbstractPageMemorySortedIndexStorageTest extends
AbstractSortedIndexStorageTest {
protected BasePageMemoryStorageEngineConfiguration<?, ?> baseEngineConfig;
+ protected Random random = ThreadLocalRandom.current();
Review Comment:
same here
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/sorted/io/SortedIndexTreeIo.java:
##########
@@ -60,7 +60,7 @@ public interface SortedIndexTreeIo {
+ PARTITIONLESS_LINK_SIZE_BYTES // Index columns link.
+ 2 * Long.BYTES; // Row ID.
- /** Index columns are not fully inlined, the index column size is {@link
#indexColumnsInlineSize()}. */
+ /** Special value that is written to the Index Key, indicating the value
has not benn fully inlined into it. */
Review Comment:
```suggestion
/** Special value that is written to the Index Key, indicating the value
has not been fully inlined into it. */
```
##########
modules/storage-page-memory/src/test/java/org/apache/ignite/internal/storage/pagememory/index/AbstractPageMemoryHashIndexStorageTest.java:
##########
@@ -40,6 +42,8 @@
abstract class AbstractPageMemoryHashIndexStorageTest extends
AbstractHashIndexStorageTest {
protected BasePageMemoryStorageEngineConfiguration<?, ?> baseEngineConfig;
+ protected Random random = ThreadLocalRandom.current();
Review Comment:
1. Should be `private` and `final`
2. I don't think this is a correct way to use `ThreadLocalRandom` (tests may
be run in parallel, theoretically), plain `Random` should suffice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
