rpuch commented on code in PR #1226: URL: https://github.com/apache/ignite-3/pull/1226#discussion_r1001859962
########## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/snapshot/outgoing/SnapshotAwarePartitionDataStorage.java: ########## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.table.distributed.raft.snapshot.outgoing; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.UUID; +import java.util.concurrent.CompletableFuture; +import org.apache.ignite.hlc.HybridTimestamp; +import org.apache.ignite.internal.lock.AutoLockup; +import org.apache.ignite.internal.schema.BinaryRow; +import org.apache.ignite.internal.storage.MvPartitionStorage; +import org.apache.ignite.internal.storage.MvPartitionStorage.WriteClosure; +import org.apache.ignite.internal.storage.ReadResult; +import org.apache.ignite.internal.storage.RowId; +import org.apache.ignite.internal.storage.StorageException; +import org.apache.ignite.internal.storage.TxIdMismatchException; +import org.apache.ignite.internal.table.distributed.raft.PartitionDataStorage; +import org.apache.ignite.internal.table.distributed.raft.snapshot.PartitionKey; +import org.apache.ignite.internal.util.Cursor; +import org.jetbrains.annotations.Nullable; +import org.jetbrains.annotations.TestOnly; + +/** + * {@link MvPartitionStorage} decorator that adds snapshot awareness. This means that writes coordinate with ongoing + * snapshots to make sure that the writes do not interfere with the snapshots. + */ +public class SnapshotAwarePartitionDataStorage implements PartitionDataStorage { Review Comment: Having an interface is good for testing. In this case, it makes it really easy to write a fake. Also, please note that this fake doesn't need to know about snapshots, so it doesn't need an instance of `PartitionsSnapshots`. It makes its usage simpler in tests. And it was really easy to write. But at the same time, we have a full-blown implementation. The fact that the full-blown implementation differs from the fake implementation in just one aspect is just a coincidence. Interfaces keep out hands free and don't cost too much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
